Scale gl3d error bars #74
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- include scaleFactor into 'errors' computations - swap value and valueminus in percent type on par with 2d
| 0 | ||
| ], | ||
| "color": "green", | ||
| "thinkness": 5 |
There was a problem hiding this comment.
I don't "think" that's what you meant
There was a problem hiding this comment.
haha good catch. Thanks.
|
Nice catch. Maybe one more test image that covers sqrt and symmetric data? |
|
💃 if you're going to make a separate PR to fix and test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@bpostlethwaite @alexcjohnson
When added support for 3d date time axes using a linear map, we forgot to make 3d error bars obey the same transformation. 3d error bars have been broken even since. Luckily this will never happen again thanks too 972461f .